aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPřemysl Janouch <p@janouch.name>2018-10-11 21:00:00 +0200
committerPřemysl Janouch <p@janouch.name>2018-10-11 21:02:45 +0200
commit9494e8e2affcd08b791d3ecf68985a8a3a310e55 (patch)
tree361c49effb7e04c66496c8ab6794eebf68800c5e
parent8ffe20c0e83b52db1344fe91f57236be4c4cb504 (diff)
downloadliberty-9494e8e2affcd08b791d3ecf68985a8a3a310e55.tar.gz
liberty-9494e8e2affcd08b791d3ecf68985a8a3a310e55.tar.xz
liberty-9494e8e2affcd08b791d3ecf68985a8a3a310e55.zip
Add some comments
-rw-r--r--liberty-proto.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/liberty-proto.c b/liberty-proto.c
index c222b97..18e7912 100644
--- a/liberty-proto.c
+++ b/liberty-proto.c
@@ -213,6 +213,7 @@ irc_fnmatch (const char *pattern, const char *string)
char x_pattern[pattern_size], x_string[string_size];
irc_strxfrm (x_pattern, pattern, pattern_size);
irc_strxfrm (x_string, string, string_size);
+ // FIXME: this supports [], which is not mentioned in RFC 2812
return fnmatch (x_pattern, x_string, 0);
}
@@ -1188,8 +1189,10 @@ ws_parser_unmask (char *payload, uint64_t len, uint32_t mask)
{
case 3:
payload[end + 2] ^= (mask >> 8) & 0xFF;
+ // Fall-through
case 2:
payload[end + 1] ^= (mask >> 16) & 0xFF;
+ // Fall-through
case 1:
payload[end ] ^= (mask >> 24) & 0xFF;
}
@@ -1738,6 +1741,8 @@ mpd_client_send_command (struct mpd_client *self, const char *command, ...)
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+/// "On success for all commands, OK is returned. If a command fails, no more
+/// commands are executed and the appropriate ACK error is returned"
static void
mpd_client_list_begin (struct mpd_client *self)
{