From 43b5536c4d6f90fdd0125928a0c2a44c89122c8b Mon Sep 17 00:00:00 2001
From: Přemysl Janouch <p@janouch.name>
Date: Fri, 12 Apr 2019 03:00:17 +0200
Subject: Fix status decoding

Mainly to reflect a real-world printer.
---
 brother-info/main.go | 16 +++++++++++-----
 label-exp/main.go    |  6 +++---
 ql/ql.go             |  2 ++
 3 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/brother-info/main.go b/brother-info/main.go
index a1584e1..33a169b 100644
--- a/brother-info/main.go
+++ b/brother-info/main.go
@@ -62,15 +62,19 @@ func printStatusInformation(d []byte) {
 	switch b := d[11]; b {
 	case 0x00:
 		log.Println("media: no media")
-	case 0x4a:
+	case 0x4a, 0x0a: // 0x4a = J, in reality we get 0x0a as in QL-1100 docs
 		log.Println("media: continuous length tape")
-	case 0x4b:
+	case 0x4b, 0x0b: // 0x4b = K, in reality we get 0x0b as in QL-1100 docs
 		log.Println("media: die-cut labels")
 	default:
 		log.Println("media:", b)
 	}
 
-	// d[14] seems to be 0x14 in a real-world QL-800.
+	// In a real-world QL-800, d[14] seems to be:
+	//  0x01 with die-cut 29mm long labels,
+	//  0x14 with 29mm tape,
+	//  0x23 with red-black 62mm tape,
+	// and directly corresponds to physical pins on the tape.
 	if d[12] != 0x00 || d[13] != 0x00 || d[14] != 0x3f {
 		log.Println("unexpected status fixed bytes")
 	}
@@ -83,7 +87,7 @@ func printStatusInformation(d []byte) {
 	}
 
 	// Media length.
-	log.Println("media width:", d[17], "mm")
+	log.Println("media length:", d[17], "mm")
 
 	// Status type.
 	switch b := d[18]; b {
@@ -128,7 +132,9 @@ func printStatusInformation(d []byte) {
 		log.Println("notification number:", b)
 	}
 
-	// d[25] seems to be 0x01 in a real-world QL-800.
+	// In a real-world QL-800, d[25] seems to be:
+	//  0x01 with 29mm tape or die-cut 29mm long labels,
+	//  0x81 with red-black 62mm tape.
 	if d[23] != 0x00 || d[24] != 0x00 || d[25] != 0x00 || d[26] != 0x00 ||
 		d[27] != 0x00 || d[28] != 0x00 || d[29] != 0x00 || d[30] != 0x00 ||
 		d[31] != 0x00 {
diff --git a/label-exp/main.go b/label-exp/main.go
index d1c203f..1f15266 100644
--- a/label-exp/main.go
+++ b/label-exp/main.go
@@ -109,9 +109,9 @@ func printStatusInformation(d []byte) {
 	switch b := d[11]; b {
 	case 0x00:
 		log.Println("media: no media")
-	case 0x4a:
+	case 0x4a, 0x0a: // 0x4a = J, in reality we get 0x0a as in QL-1100 docs
 		log.Println("media: continuous length tape")
-	case 0x4b:
+	case 0x4b, 0x0b: // 0x4b = K, in reality we get 0x0b as in QL-1100 docs
 		log.Println("media: die-cut labels")
 	default:
 		log.Println("media:", b)
@@ -121,7 +121,7 @@ func printStatusInformation(d []byte) {
 	log.Println("mode:", d[15])
 
 	// Media length.
-	log.Println("media width:", d[17], "mm")
+	log.Println("media length:", d[17], "mm")
 
 	// Status type.
 	switch b := d[18]; b {
diff --git a/ql/ql.go b/ql/ql.go
index 9f507da..8db263d 100644
--- a/ql/ql.go
+++ b/ql/ql.go
@@ -2,6 +2,8 @@
 package ql
 
 // Resources:
+//  http://etc.nkadesign.com/Printers/QL550LabelPrinterProtocol
+//  https://github.com/torvalds/linux/blob/master/drivers/usb/class/usblp.c
 //  http://www.undocprint.org/formats/page_description_languages/brother_p-touch
 
 import (
-- 
cgit v1.2.3-70-g09d2