From e86f4b6908559c34bdf60f1f2d4f303a188f386d Mon Sep 17 00:00:00 2001
From: Přemysl Eric Janouch <p@janouch.name>
Date: Sat, 24 Oct 2020 15:44:12 +0200
Subject: Comment the "poll_elapsed_time" option

---
 nncmpp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/nncmpp.c b/nncmpp.c
index 111ba12..d0d2c85 100644
--- a/nncmpp.c
+++ b/nncmpp.c
@@ -744,6 +744,12 @@ static struct config_schema g_config_settings[] =
 	{ .name      = "root",
 	  .comment   = "Where all the files MPD is playing are located",
 	  .type      = CONFIG_ITEM_STRING },
+
+	// Disabling this minimises MPD traffic and has the following caveats:
+	//  - when MPD stalls on retrieving audio data, we keep ticking
+	//  - when the "play" succeeds in ACTION_MPD_REPLACE for the same item as
+	//    is currently playing, we do not reset g.song_elapsed (we could ask
+	//    for a response which feels racy, or rethink the mechanism there)
 	{ .name      = "poll_elapsed_time",
 	  .comment   = "Whether to actively poll MPD for the elapsed time",
 	  .type      = CONFIG_ITEM_BOOLEAN,
-- 
cgit v1.2.3-70-g09d2