aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPřemysl Eric Janouch <p@janouch.name>2020-10-24 15:44:12 +0200
committerPřemysl Eric Janouch <p@janouch.name>2020-10-24 15:44:12 +0200
commite86f4b6908559c34bdf60f1f2d4f303a188f386d (patch)
treeb53d2076aa67509a1c242d4f3f99e9fca0667545
parent26b6b1f902e69b852431c2e510adbfbb3dbe009b (diff)
downloadnncmpp-e86f4b6908559c34bdf60f1f2d4f303a188f386d.tar.gz
nncmpp-e86f4b6908559c34bdf60f1f2d4f303a188f386d.tar.xz
nncmpp-e86f4b6908559c34bdf60f1f2d4f303a188f386d.zip
Comment the "poll_elapsed_time" option
-rw-r--r--nncmpp.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/nncmpp.c b/nncmpp.c
index 111ba12..d0d2c85 100644
--- a/nncmpp.c
+++ b/nncmpp.c
@@ -744,6 +744,12 @@ static struct config_schema g_config_settings[] =
{ .name = "root",
.comment = "Where all the files MPD is playing are located",
.type = CONFIG_ITEM_STRING },
+
+ // Disabling this minimises MPD traffic and has the following caveats:
+ // - when MPD stalls on retrieving audio data, we keep ticking
+ // - when the "play" succeeds in ACTION_MPD_REPLACE for the same item as
+ // is currently playing, we do not reset g.song_elapsed (we could ask
+ // for a response which feels racy, or rethink the mechanism there)
{ .name = "poll_elapsed_time",
.comment = "Whether to actively poll MPD for the elapsed time",
.type = CONFIG_ITEM_BOOLEAN,