From bb224bafd043e07fd18e3d8cda2c3f41c132e507 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C5=99emysl=20Janouch?= Date: Sat, 11 Aug 2012 21:00:38 +0200 Subject: More fixing. * Fix a resource leak in LdLibrary. * Add missing property change notifiers to ld_diagram_object_{get,set}_storage(). * Don't unref the parameter in ld_symbol_category_remove_{symbol,subcategory} if it wasn't actually removed from the internal list. * Fix a cyclic dependency problem in LdDiagram. --- liblogdiag/ld-symbol-category.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'liblogdiag/ld-symbol-category.c') diff --git a/liblogdiag/ld-symbol-category.c b/liblogdiag/ld-symbol-category.c index d8150dc..4c35c4c 100644 --- a/liblogdiag/ld-symbol-category.c +++ b/liblogdiag/ld-symbol-category.c @@ -325,8 +325,11 @@ ld_symbol_category_remove_symbol (LdSymbolCategory *self, g_return_if_fail (LD_IS_SYMBOL_CATEGORY (self)); g_return_if_fail (LD_IS_SYMBOL (symbol)); - g_object_unref (symbol); - self->priv->symbols = g_slist_remove (self->priv->symbols, symbol); + if (g_slist_find (self->priv->symbols, symbol)) + { + self->priv->symbols = g_slist_remove (self->priv->symbols, symbol); + g_object_unref (symbol); + } } /** @@ -378,9 +381,12 @@ ld_symbol_category_remove_subcategory (LdSymbolCategory *self, g_return_if_fail (LD_IS_SYMBOL_CATEGORY (self)); g_return_if_fail (LD_IS_SYMBOL_CATEGORY (category)); - g_object_unref (category); - self->priv->subcategories - = g_slist_remove (self->priv->subcategories, category); + if (g_slist_find (self->priv->subcategories, category)) + { + self->priv->subcategories + = g_slist_remove (self->priv->subcategories, category); + g_object_unref (category); + } } /** -- cgit v1.2.3