aboutsummaryrefslogtreecommitdiff
path: root/liblogdiag/ld-library.c
diff options
context:
space:
mode:
authorPřemysl Janouch <p.janouch@gmail.com>2012-08-29 21:56:59 +0200
committerPřemysl Janouch <p.janouch@gmail.com>2012-10-08 07:29:57 +0200
commit77aad430ef77b89835c8e04995b11fabeed044fb (patch)
tree9588fd36875d9024f80a8382c6f96bb4cad4d421 /liblogdiag/ld-library.c
parent2156a92a098433f3e3a570bda9f2ab4e5ab53dcf (diff)
downloadlogdiag-77aad430ef77b89835c8e04995b11fabeed044fb.tar.gz
logdiag-77aad430ef77b89835c8e04995b11fabeed044fb.tar.xz
logdiag-77aad430ef77b89835c8e04995b11fabeed044fb.zip
Add `changed' signals to LdCategory.
Diffstat (limited to 'liblogdiag/ld-library.c')
-rw-r--r--liblogdiag/ld-library.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/liblogdiag/ld-library.c b/liblogdiag/ld-library.c
index 2b4c704..75e377c 100644
--- a/liblogdiag/ld-library.c
+++ b/liblogdiag/ld-library.c
@@ -328,6 +328,16 @@ ld_library_load (LdLibrary *self, const gchar *directory)
data.changed = FALSE;
foreach_dir (directory, load_category_cb, &data, NULL);
+ /* XXX: It might also make sense to just forward the "children-changed"
+ * signal of the root category but we'd have to block it here anyway,
+ * so that we don't unnecessarily fire events for every single change.
+ *
+ * The user code isn't supposed to make changes to / and it's its own
+ * problem if it keeps reloading something a hundred times in a row.
+ *
+ * That said, it'd be possible to add change grouping methods to
+ * LdCategory and so delay the signal emission until an `unblock'.
+ */
if (data.changed)
g_signal_emit (self, LD_LIBRARY_GET_CLASS (self)->changed_signal, 0);