summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPřemysl Janouch <p.janouch@gmail.com>2011-01-29 13:09:16 +0100
committerPřemysl Janouch <p.janouch@gmail.com>2011-01-29 13:09:16 +0100
commit400568ed7d9fd92b4b114c5a79fc174092593f64 (patch)
treee6d90a896aaf5b019671ab6a6d586fa4acd88522
parentcf3e4ae47341f5e72d389b5b5e35a1a778c14977 (diff)
downloadlogdiag-400568ed7d9fd92b4b114c5a79fc174092593f64.tar.gz
logdiag-400568ed7d9fd92b4b114c5a79fc174092593f64.tar.xz
logdiag-400568ed7d9fd92b4b114c5a79fc174092593f64.zip
Add some reminder comments.
-rw-r--r--liblogdiag/ld-library-toolbar.c3
-rw-r--r--src/ld-window-main.c1
2 files changed, 4 insertions, 0 deletions
diff --git a/liblogdiag/ld-library-toolbar.c b/liblogdiag/ld-library-toolbar.c
index d1ceb9c..b18980f 100644
--- a/liblogdiag/ld-library-toolbar.c
+++ b/liblogdiag/ld-library-toolbar.c
@@ -443,6 +443,9 @@ load_category_cb (gpointer data, gpointer user_data)
g_object_set (button, "can-focus", FALSE, NULL);
/* Assign the category to the toggle button. */
+ /* TODO: Move this to the data parameter for the signal handler.
+ * Use g_signal_connect_data() to set up destroy notification.
+ */
g_object_ref (cat);
g_object_set_data_full (G_OBJECT (button),
"category", cat, (GDestroyNotify) g_object_unref);
diff --git a/src/ld-window-main.c b/src/ld-window-main.c
index f7d9f8d..4f3e603 100644
--- a/src/ld-window-main.c
+++ b/src/ld-window-main.c
@@ -510,6 +510,7 @@ diagram_save (LdWindowMain *self)
return;
}
+ /* FIXME: If this fails, we still retain the filename. */
error = NULL;
ld_diagram_save_to_file (self->priv->diagram,
self->priv->filename, &error);