From 2201becca443c28cb722b6a536b70a5f5d144124 Mon Sep 17 00:00:00 2001
From: Přemysl Eric Janouch <p@janouch.name>
Date: Sat, 10 Oct 2020 04:29:41 +0200
Subject: Mark some issues
---
liberty.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/liberty.c b/liberty.c
index 8fc4cb0..1de6a35 100644
--- a/liberty.c
+++ b/liberty.c
@@ -1357,6 +1357,7 @@ struct poller_idle
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
+// The heap could definitely be made faster but we'll prefer simplicity
struct poller_timers
{
struct poller_timer **heap; ///< Min-heap of timers
@@ -3002,6 +3003,7 @@ iconv_xstrdup (iconv_t conv, char *in, size_t in_len, size_t *out_len)
char *in_ptr = in;
if (in_len == (size_t) -1)
+ // XXX: out_len will be one character longer than the string!
in_len = strlen (in) + 1;
while (iconv (conv, (char **) &in_ptr, &in_len,
--
cgit v1.2.3-70-g09d2