aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--liberty.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/liberty.c b/liberty.c
index 4d27127..e438c34 100644
--- a/liberty.c
+++ b/liberty.c
@@ -3552,6 +3552,8 @@ write_file_safe (const char *filename, const void *data, size_t data_len,
{
// XXX: ideally we would also open the directory, use *at() versions
// of functions and call fsync() on the directory as appropriate
+ // FIXME: this should behave similarly to mkstemp(), just with 0666;
+ // as it is, this function is not particularly safe
char *temp = xstrdup_printf ("%s.new", filename);
bool success = write_file (temp, data, data_len, e);
if (success && !(success = !rename (temp, filename)))