From 5c34a6846ac874ada6b64eec9e140cb4e9b04291 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C5=99emysl=20Eric=20Janouch?= Date: Wed, 9 Mar 2022 17:58:19 +0100 Subject: Fix loading huge JPEGs They fell back to gdk-pixbuf, then misrendered in the thumbnailer, and crashed the program when loaded directly. The second best we can do is scale them down, right after tiling, which is a complex feature to add. --- fiv-thumbnail.c | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'fiv-thumbnail.c') diff --git a/fiv-thumbnail.c b/fiv-thumbnail.c index 7bbfc92..d1d67c4 100644 --- a/fiv-thumbnail.c +++ b/fiv-thumbnail.c @@ -163,6 +163,15 @@ adjust_thumbnail(cairo_surface_t *thumbnail, double row_height) cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE); cairo_paint(cr); + + // Note that this doesn't get triggered with oversize input surfaces, + // even though nothing will be rendered. + if (cairo_surface_status(thumbnail) != CAIRO_STATUS_SUCCESS || + cairo_surface_status(scaled) != CAIRO_STATUS_SUCCESS || + cairo_pattern_status(pattern) != CAIRO_STATUS_SUCCESS || + cairo_status(cr) != CAIRO_STATUS_SUCCESS) + g_warning("thumbnail scaling failed"); + cairo_destroy(cr); return scaled; } -- cgit v1.2.3