aboutsummaryrefslogtreecommitdiff
path: root/fiv-browser.c
diff options
context:
space:
mode:
authorPřemysl Eric Janouch <p@janouch.name>2021-12-30 22:52:23 +0100
committerPřemysl Eric Janouch <p@janouch.name>2021-12-31 00:41:04 +0100
commit5f8dc88fa715563c3abb8ed0d8ae5d2736f7a1a9 (patch)
tree3434d40e8eb5427fc0da5d5e41325c511e16c44e /fiv-browser.c
parent380ddd540bd93850e4df254200cba5b1fdf05cc6 (diff)
downloadfiv-5f8dc88fa715563c3abb8ed0d8ae5d2736f7a1a9.tar.gz
fiv-5f8dc88fa715563c3abb8ed0d8ae5d2736f7a1a9.tar.xz
fiv-5f8dc88fa715563c3abb8ed0d8ae5d2736f7a1a9.zip
Minor URL-related fix-ups
Diffstat (limited to 'fiv-browser.c')
-rw-r--r--fiv-browser.c16
1 files changed, 3 insertions, 13 deletions
diff --git a/fiv-browser.c b/fiv-browser.c
index 39e2528..d426454 100644
--- a/fiv-browser.c
+++ b/fiv-browser.c
@@ -488,7 +488,6 @@ on_thumbnailer_ready(GObject *object, GAsyncResult *res, gpointer user_data)
if (succeeded)
thumbnailer_reprocess_entry(self, entry);
- // TODO(p): Eliminate high recursion depth with non-paths.
thumbnailer_next(self);
}
@@ -496,26 +495,17 @@ static void
thumbnailer_next(FivBrowser *self)
{
// TODO(p): At least launch multiple thumbnailers in parallel.
+ // Ideally, try to keep them alive.
GList *link = self->thumbnail_queue;
if (!link)
return;
const Entry *entry = link->data;
- GFile *file = g_file_new_for_uri(entry->uri);
- gchar *uri = g_file_get_uri(file);
- g_object_unref(file);
- if (!uri) {
- // TODO(p): Support thumbnailing non-local URIs in some manner.
- self->thumbnail_queue = g_list_delete_link(self->thumbnail_queue, link);
- return;
- }
-
GError *error = NULL;
self->thumbnailer = g_subprocess_new(G_SUBPROCESS_FLAGS_NONE, &error,
PROJECT_NAME, "--thumbnail",
- fiv_thumbnail_sizes[self->item_size].thumbnail_spec_name, "--", uri,
- NULL);
- g_free(uri);
+ fiv_thumbnail_sizes[self->item_size].thumbnail_spec_name, "--",
+ entry->uri, NULL);
if (error) {
g_warning("%s", error->message);
g_error_free(error);