aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPřemysl Eric Janouch <p@janouch.name>2021-12-20 03:49:07 +0100
committerPřemysl Eric Janouch <p@janouch.name>2021-12-20 03:49:35 +0100
commit6130f527d473cab7681024a25fe8d46c9c144c3b (patch)
tree4257a85c12763eab4742ca16e349ab30a6318ac4
parent3da1d32df764ee45b29dc407353fd0e7a561912c (diff)
downloadfiv-6130f527d473cab7681024a25fe8d46c9c144c3b.tar.gz
fiv-6130f527d473cab7681024a25fe8d46c9c144c3b.tar.xz
fiv-6130f527d473cab7681024a25fe8d46c9c144c3b.zip
Mark a dead end
-rw-r--r--fastiv.c16
1 files changed, 10 insertions, 6 deletions
diff --git a/fastiv.c b/fastiv.c
index 14380eb..df99908 100644
--- a/fastiv.c
+++ b/fastiv.c
@@ -837,12 +837,16 @@ toolbar_connect(int index, GCallback callback)
g_signal_connect_swapped(g.toolbar[index], "clicked", callback, NULL);
}
-// TODO(p): The toolbar should not be visible in fullscreen,
-// or show up only when the cursor reaches the bottom of the screen.
-// Presumably, GtkOverlay could be used for this. Proximity-based?
-// Might want to make the toolbar normally translucent.
-// TODO(p): The text and icons should be faded, unless the mouse cursor
-// is on the toolbar.
+// TODO(p): The text and icons should be faded, unless the mouse cursor is
+// on the toolbar. However, GtkEventBox is of no use, because either buttons
+// steal our {enter,leave}-notify-events, or we steal all their input.
+// Not even connecting to these signals on children works, insensitive buttons
+// will not trigger anything.
+// TODO(p): The toolbar should not be visible in fullscreen, or should show up
+// only when the cursor reaches the top of the screen. Translucency sounds
+// like a good mechanism here. Presumably, GtkOverlay could be used for this,
+// but it faces the same problem as above--the input model sucks.
+// TODO(p): Simply hide it in fullscreen and add a replacement context menu.
static GtkWidget *
make_view_toolbar(void)
{